bpo-33595: Fix lambda parameters being refered as arguments #7037
Conversation
|
Thanks @andresdelfino for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
(cherry picked from commit 268cc7c) Co-authored-by: Andrés Delfino <[email protected]>
|
GH-7040 is a backport of this pull request to the 3.7 branch. |
|
@andresdelfino Thanks! |
(cherry picked from commit 268cc7c) Co-authored-by: Andrés Delfino <[email protected]>
|
GH-7041 is a backport of this pull request to the 3.6 branch. |
(cherry picked from commit 268cc7c) Co-authored-by: Andrés Delfino <[email protected]>
(cherry picked from commit 268cc7c) Co-authored-by: Andrés Delfino <[email protected]>
|
Should I cherry-pick the commit to backport the fix to 2.7? |
|
Thanks @andresdelfino for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7. |
|
Sorry, @andresdelfino and @JulienPalard, I could not cleanly backport this to |
|
GH-7122 is a backport of this pull request to the 2.7 branch. |
|
Julien, The commit message did not have the "bpo-33595: " prefix. Hence the backports were missing the prefixes. Hence the backports were not listed on the issue, and one could not tell from the issue that the backports had been done. Andres, I added a 2.7 backport label, but there is a conflict. While checking why (the function name in the def equivalent), I made the changes and 2.7 PR. |
…-7037) (GH-7122) (cherry picked from commit 268cc7c) Co-authored-by: Andrés Delfino [email protected]
|
Andrés, it appears that you created the PR without the bpo prefix, and that it was added later (due to the CI message). Unfortunately, Github's default title for commits is the original PR title, not the corrected title. |
|
Yes, that is exactly what happened! |
|
@terryjreedy woops I in fact missed this point, sorry for this. I followed closely https://devguide.python.org/committing/#is-the-pr-ready-to-be-accepted but jumped a bit fast on the "squash and merge", overlooking https://devguide.python.org/gitbootcamp/#accepting-and-merging-a-pull-request, my bad. |
|
I consider it a Github bug that it resurrects the initial version of the title to use as the default merge title. I still occasionally forget to replace '#' with 'GH-', so I now make myself pause between initial and confirmatory clicks. Slower can be faster ;-). |
https://bugs.python.org/issue33595