bpo-33349: make lib2to3 parse async generators everywhere #6588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZackerySpytz
reviewed
Apr 9, 2019
| @@ -0,0 +1 @@ | |||
| lib2to3 now recognizes async generators everywhere. | |||
There was a problem hiding this comment.
I think the news entry needs more details -- it's currently rather vague.
There was a problem hiding this comment.
How about "lib2to3 now recognizes async generators in non-async contexts"?
There was a problem hiding this comment.
I have no opposition to the current version though the one you proposed also OK.
|
Is this issue addressed? What would it take to merge this? |
isidentical
approved these changes
Mar 7, 2020
| @@ -0,0 +1 @@ | |||
| lib2to3 now recognizes async generators everywhere. | |||
There was a problem hiding this comment.
I have no opposition to the current version though the one you proposed also OK.
ambv
force-pushed
the
2to3-async-generator
branch
from
75a4ece to
4d45397
Compare
ambv
added
needs backport to 3.9
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 10, 2021
(cherry picked from commit 149addd) Co-authored-by: Zsolt Dollenstein <[email protected]>
|
GH-27702 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 10, 2021
(cherry picked from commit 149addd) Co-authored-by: Zsolt Dollenstein <[email protected]>
|
GH-27703 is a backport of this pull request to the 3.9 branch. |
ambv
pushed a commit
that referenced
this pull request
Aug 10, 2021
(cherry picked from commit 149addd) Co-authored-by: Zsolt Dollenstein <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Aug 10, 2021
(cherry picked from commit 149addd) Co-authored-by: Zsolt Dollenstein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The caveat with this implementation is that it also accepts the following without raising SyntaxError:
https://bugs.python.org/issue33349