-
-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backport to 2.7] Change documentation's Show Source
link to GitHub
#44
Conversation
Change the url to 2.7 (cherry picked from commit 79ab8be)
Doc/tools/extensions/pyspecific.py
Outdated
@@ -58,7 +58,7 @@ def new_depart_literal_block(self, node): | |||
|
|||
def issue_role(typ, rawtext, text, lineno, inliner, options={}, content=[]): | |||
issue = utils.unescape(text) | |||
text = 'issue ' + issue | |||
text = 'bpo- ' + issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there space between 'bpo-' and issue number?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, there shouldn't be a space 😅
Thanks for the review :) Will fix soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did make html
in local, and it works as expected.
LGTM.
Show Source
link to GitHub
Thanks @methane :) I updated the pull request description. |
LGTM |
The link we have points to the version from Unicode 6.0.0, dated 2010. There have been numerous updates to it since then: https://www.unicode.org/reports/tr44/#Modifications Change the link to one that points to the current version.
) The link we have points to the version from Unicode 6.0.0, dated 2010. There have been numerous updates to it since then: https://www.unicode.org/reports/tr44/#Modifications Change the link to one that points to the current version. Also, use HTTPS.
pythonGH-15301) The link we have points to the version from Unicode 6.0.0, dated 2010. There have been numerous updates to it since then: https://www.unicode.org/reports/tr44/GH-Modifications Change the link to one that points to the current version. Also, use HTTPS. (cherry picked from commit 64c6ac7) Co-authored-by: Greg Price <[email protected]>
pythonGH-15301) The link we have points to the version from Unicode 6.0.0, dated 2010. There have been numerous updates to it since then: https://www.unicode.org/reports/tr44/GH-Modifications Change the link to one that points to the current version. Also, use HTTPS. (cherry picked from commit 64c6ac7) Co-authored-by: Greg Price <[email protected]>
GH-15301) The link we have points to the version from Unicode 6.0.0, dated 2010. There have been numerous updates to it since then: https://www.unicode.org/reports/tr44/GH-Modifications Change the link to one that points to the current version. Also, use HTTPS.. (cherry picked from commit 64c6ac7) Co-authored-by: Greg Price <[email protected]>
GH-15808) The link we have points to the version from Unicode 6.0.0, dated 2010. There have been numerous updates to it since then: https://www.unicode.org/reports/tr44/GH-Modifications Change the link to one that points to the current version. Also, use HTTPS.. (cherry picked from commit 64c6ac7) Co-authored-by: Greg Price <[email protected]>
…15301) The link we have points to the version from Unicode 6.0.0, dated 2010. There have been numerous updates to it since then: https://www.unicode.org/reports/tr44/GH-Modifications Change the link to one that points to the current version. Also, use HTTPS. (cherry picked from commit 64c6ac7) Co-authored-by: Greg Price <[email protected]>
…15301) The link we have points to the version from Unicode 6.0.0, dated 2010. There have been numerous updates to it since then: https://www.unicode.org/reports/tr44/GH-Modifications Change the link to one that points to the current version. Also, use HTTPS. (cherry picked from commit 64c6ac7) Co-authored-by: Greg Price <[email protected]>
…ythonGH-15301) The link we have points to the version from Unicode 6.0.0, dated 2010. There have been numerous updates to it since then: https://www.unicode.org/reports/tr44/#Modifications Change the link to one that points to the current version. Also, use HTTPS.
Fix `contents()` so that it no longer returns unrelated items Closes python#44 See merge request python-devs/importlib_resources!48
Change documentation's
Show Source
link to GitHub (2.7 branch)Render issue role as bpo-NNNN