Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-47098: Replace Keccak Code Package with tiny_sha3 (GH-32060) #32060

Merged
merged 4 commits into from
Mar 26, 2022
Merged

bpo-47098: Replace Keccak Code Package with tiny_sha3 (GH-32060) #32060

merged 4 commits into from
Mar 26, 2022

Conversation

tiran
Copy link
Member

@tiran tiran commented Mar 22, 2022 •
edited by bedevere-bot
Loading

@tiran tiran added DO-NOT-MERGE 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Mar 22, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @tiran for commit 62f315c3be2ac37cee8df06d03b979fcda41b219 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot added awaiting core review and removed 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Mar 22, 2022
gpshead
gpshead reviewed Mar 22, 2022
View reviewed changes
Copy link
Member

@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hah, that one is amazingly small. nice.

Modules/_sha3/README.txt Show resolved Hide resolved
@tiran tiran changed the title Test with tiny_sha3 bpo-47098: Replace Keccak Code Package with tiny_sha3 Mar 23, 2022
@tiran tiran marked this pull request as ready for review March 23, 2022 09:21
@tiran
Copy link
Member Author

tiran commented Mar 23, 2022

hah, that one is amazingly small. nice.

Wait until you size the binary size! It's 380kB -> 69 kB (stripped 90kB -> 25kB).

@tiran tiran added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section and removed DO-NOT-MERGE labels Mar 23, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @tiran for commit e8fd0118edcd9f53686d63e417f3799620a29bdd 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 23, 2022
@tiran tiran requested a review from gpshead March 25, 2022 18:58
@tiran
Copy link
Member Author

tiran commented Mar 25, 2022

@gpshead please take another look

gpshead
gpshead reviewed Mar 26, 2022
View reviewed changes
Misc/NEWS.d/next/Library/2022-03-23-10-07-41.bpo-47098.7AN_qp.rst Outdated Show resolved Hide resolved
Modules/_sha3/LICENSE Outdated Show resolved Hide resolved
Modules/_sha3/sha3module.c Show resolved Hide resolved
@tiran tiran changed the title bpo-47098: Replace Keccak Code Package with tiny_sha3 bpo-47098: Replace Keccak Code Package with tiny_sha3 (GH-32060) Mar 26, 2022
@tiran tiran merged commit 5fd8c57 into python:main Mar 26, 2022
@tiran tiran deleted the tiny_sha3 branch March 26, 2022 20:36
This was referenced Mar 26, 2022
Closed
Closed
@botovq botovq mentioned this pull request Oct 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiran @bedevere-bot @gpshead @the-knights-who-say-ni