bpo-44035: Check autoconf files thoroughly (GH-29935) #29935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiran
added
needs backport to 3.9
tiran
changed the title
Check that users don't push changes with outdated or patched autoconf. The presence of runstatedir option and aclocal 1.16.3 are good markers. Use my container image to regenerate autoconf files. "Check for changes" will fail later when any file is regenerated. Use ccache in check_generated_files to speed up testing. Signed-off-by: Christian Heimes <[email protected]>
|
Can we make one step further and use GitHub API to automatically add a file-wide review with a |
That's an interesting idea and certainly helpful for new contributors. Could you please open a new ticket for your proposal? |
|
Why not just add a Something like this: diff --git a/Makefile.pre.in b/Makefile.pre.in
index 8e6e553554..5afe48a26f 100644
--- a/Makefile.pre.in
+++ b/Makefile.pre.in
@@ -1156,6 +1156,10 @@ Python/frozen_modules/getpath.h: $(FREEZE_MODULE) Modules/getpath.py
Tools/scripts/freeze_modules.py: $(FREEZE_MODULE)
+.PHONY: regen-autoconf
+regen-autoconf: configure.ac configure aclocal.m4
+ @docker run --rm -v $(shell pwd):/src quay.io/tiran/cpython_autoconf:269
+
.PHONY: regen-frozen
regen-frozen: Tools/scripts/freeze_modules.py $(FROZEN_FILES_IN)
$(PYTHON_FOR_REGEN) $(srcdir)/Tools/scripts/freeze_modules.py
@@ -1176,7 +1180,7 @@ regen-limited-abi: all
regen-all: regen-opcode regen-opcode-targets regen-typeslots \
regen-token regen-ast regen-keyword regen-frozen clinic \
- regen-pegen-metaparser regen-pegen regen-test-frozenmain
+ regen-pegen-metaparser regen-pegen regen-test-frozenmain regen-autoconf
@echo
@echo "Note: make regen-stdlib-module-names and autoconf should be run manually"
|
|
Because it's not that simple. Platforms with mandatory access control and LSMs need extra options. For example SELinux enforcing systems require |
Ah, true. I was only thinking of the CI, but of course the Makefile has a wider audience. |
tiran
changed the title
|
Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
|
Sorry, @tiran, I could not cleanly backport this to |
|
GH-29937 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 6, 2021
Check that users don't push changes with outdated or patched autoconf. The presence of runstatedir option and aclocal 1.16.3 are good markers. Use my container image to regenerate autoconf files. "Check for changes" will fail later when any file is regenerated. Use ccache in check_generated_files to speed up testing. (cherry picked from commit 98fac8b) Co-authored-by: Christian Heimes <[email protected]>
tiran
added a commit
to tiran/cpython
that referenced
this pull request
Dec 6, 2021
Check that users don't push changes with outdated or patched autoconf. The presence of runstatedir option and aclocal 1.16.3 are good markers. Use my container image to regenerate autoconf files. "Check for changes" will fail later when any file is regenerated. Use ccache in check_generated_files to speed up testing.. (cherry picked from commit 98fac8b) Co-authored-by: Christian Heimes <[email protected]>
|
GH-29938 is a backport of this pull request to the 3.9 branch. |
tiran
added a commit
that referenced
this pull request
Dec 6, 2021
Co-authored-by: Christian Heimes <[email protected]>
tiran
added a commit
that referenced
this pull request
Dec 6, 2021
Co-authored-by: Christian Heimes <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that users don't push changes with outdated or patched autoconf.
The presence of runstatedir option and aclocal 1.16.3 are good markers.
Use my container image to regenerate autoconf files. "Check for changes"
will fail later when any file is regenerated.
Use ccache in check_generated_files to speed up testing.
https://bugs.python.org/issue44035