Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-43970: Optimize Path.cwd() in pathlib #25699

Merged
merged 1 commit into from
Apr 28, 2021
Merged

bpo-43970: Optimize Path.cwd() in pathlib #25699

merged 1 commit into from
Apr 28, 2021

Conversation

kfollstad
Copy link
Contributor

@kfollstad kfollstad commented Apr 28, 2021 •
edited by bedevere-bot
Loading

Avoid instantiating a class unnecessarily.

https://bugs.python.org/issue43970

@domdfcoding
Copy link
Contributor

cc @barneygale as I've seen you've been working on improving pathlib

@barneygale
Copy link
Contributor

LGTM! This wasn't previously possible because _accessor was set at initialization time, but that changed in 2219187.

+1 from me.

@ericvsmith ericvsmith merged commit 4a85718 into python:master Apr 28, 2021
@barneygale
Copy link
Contributor

@kfollstad thanks very much!

@kfollstad kfollstad mentioned this pull request Apr 29, 2021
Merged
@kfollstad kfollstad deleted the PathlibCwdFix branch April 29, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kfollstad @domdfcoding @barneygale @ericvsmith @the-knights-who-say-ni @bedevere-bot