Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-43083: Fix error handling in _sqlite3 #24395

Merged
merged 1 commit into from
Jan 31, 2021
Merged

bpo-43083: Fix error handling in _sqlite3 #24395

merged 1 commit into from
Jan 31, 2021

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jan 31, 2021 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error skip news needs backport to 3.8 needs backport to 3.9 only security fixes labels Jan 31, 2021
@serhiy-storchaka
Copy link
Member Author

No NEWS entry is needed because it is very difficult (if possible) to reproduce these bugs, and it is very difficult to explain the fix to average Python user without referring to internal implementation details.

berkerpeksag
berkerpeksag approved these changes Jan 31, 2021
View reviewed changes
Copy link
Member

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Not sure about backporting to 3.8 and 3.9, though. 3.9 may make sense to make future auto-backports a bit easier, but I'd probably leave 3.8 alone.

@serhiy-storchaka serhiy-storchaka merged commit 9073180 into python:master Jan 31, 2021
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the sqlite-cursor-PyList_Append branch January 31, 2021 15:42
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 31, 2021
@serhiy-storchaka @miss-islington
bpo-43083: Fix error handling in _sqlite3 (pythonGH-24395)
0997efd 
(cherry picked from commit 9073180)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jan 31, 2021
@bedevere-bot
Copy link

GH-24400 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Jan 31, 2021
@miss-islington @serhiy-storchaka
bpo-43083: Fix error handling in _sqlite3 (GH-24395)
8a833a6 
(cherry picked from commit 9073180)

Co-authored-by: Serhiy Storchaka <[email protected]>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@serhiy-storchaka @adorilson
bpo-43083: Fix error handling in _sqlite3 (pythonGH-24395)
fd43bbf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

Assignees
No one assigned
Labels
skip news type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serhiy-storchaka @miss-islington @bedevere-bot @berkerpeksag @the-knights-who-say-ni