bpo-42927: Update the What's new entry for LOAD_ATTR optimizations #24383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
reviewed
Jan 30, 2021
Doc/whatsnew/3.10.rst
Outdated
| current most performance attribute access method (faster than slots). | ||
| (Contributed by Pablo Galindo and Yury Selivanov in :issue:`42093`, based on | ||
| ideas implemented originally in PyPy and MicroPython.) | ||
| is about 36% faster now for regular attributes and 30% for slots. |
There was a problem hiding this comment.
Honestly the 30% is a pretty wild guess -- your 36% clearly is not. I'm not even sure how to really measure this, given that when I build Python from source it's somewhat slower than the python.org binary. I assume this is because of PGO or other compiler flags. (Not --with-pydebug, that is much slower still.)
Up to you if you still want to put it this way.
There was a problem hiding this comment.
I did some more rigurous measurements for slots and I have updated the text.
|
Wow! |
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue42927