Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-30711: getaddrinfo invalid port number #2436

Closed
wants to merge 4 commits into from

Conversation

smejkar
Copy link
Contributor

@smejkar smejkar commented Jun 27, 2017

smejkar added 4 commits June 27, 2017 10:31
Define HAVE_BROKEN_GETADDRINFO if the getaddrinfo function does not
detect invalid numeric services.
If the getaddrinfo function does not detect invalid numeric services,
replace it with a wrapper that returns an error code if the port number
is invalid, and calls the getaddrinfo function otherwise.
Return an error code if servname is an invalid numeric service.
Copy link

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re base needed

@csabella
Copy link
Contributor

I'm going to close it as inactive. If the original author is interested in continuing to work on it, it can be reopened or someone else can create a new pull request to replace it. If the original author's work is used in a new PR, please give the appropriate credit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants