Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42986: Fix parser crash when reporting syntax errors in f-string with newlines #24279

Merged
merged 3 commits into from
Jan 31, 2021
Merged

bpo-42986: Fix parser crash when reporting syntax errors in f-string with newlines #24279

merged 3 commits into from
Jan 31, 2021

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Jan 20, 2021 •
edited by bedevere-bot
Loading

@pablogsal pablogsal requested a review from lysnikolaou January 20, 2021 23:43
@pablogsal pablogsal changed the title Fix parser crash when reporting syntax errors in f-string with newlines bpo-42986: Fix parser crash when reporting syntax errors in f-string with newlines Jan 20, 2021
@pablogsal
Copy link
Member Author

pablogsal commented Jan 20, 2021 •
edited
Loading

@lysnikolaou Is late here and I am a bit suspicious that this is enough (we only go to the new get_error_line() if the error happens before p->tok->lineno). Please, check that we are not missing any important case that you had in mind when adding the function

@pablogsal
Copy link
Member Author

I am landing this to give it some time to be tested until the Febrary alpha. We can fix it if something is missing in the future.

@pablogsal pablogsal merged commit 4090151 into python:master Jan 31, 2021
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@pablogsal @adorilson
bpo-42986: Fix parser crash when reporting syntax errors in f-string …
e52d3cc 
…with newlines (pythonGH-24279)
@pablogsal pablogsal deleted the bpo-42986 branch May 19, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pablogsal @the-knights-who-say-ni @bedevere-bot