Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.9] bpo-40550: Fix time-of-check/time-of-action issue in subprocess.Popen.send_signal. (GH-20010) #23439

Merged
merged 1 commit into from
Nov 21, 2020

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Nov 21, 2020

send_signal() now swallows the exception if the process it thought was still alive winds up not to exist anymore (always a plausible race condition despite the checks).

Co-authored-by: Gregory P. Smith [email protected]
(cherry picked from commit 01a202a)

Co-authored-by: Filipe Laíns [email protected]

https://bugs.python.org/issue40550

Automerge-Triggered-By: GH:gpshead

….send_signal. (pythonGH-20010)

send_signal() now swallows the exception if the process it thought was still alive winds up not to exist anymore (always a plausible race condition despite the checks).

Co-authored-by: Gregory P. Smith <[email protected]>
(cherry picked from commit 01a202a)

Co-authored-by: Filipe Laíns <[email protected]>
@miss-islington
Copy link
Contributor Author

@FFY00 and @gpshead: Status check is done, and it's a success ✅ .

@gpshead gpshead added 🤖 automerge type-bug An unexpected behavior, bug, or error labels Nov 21, 2020
@miss-islington
Copy link
Contributor Author

@FFY00 and @gpshead: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 713b4bb into python:3.9 Nov 21, 2020
@miss-islington miss-islington deleted the backport-01a202a-3.9 branch November 21, 2020 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants