bpo-29406: asyncio SSL protocol leaks sockets after calling close with certain servers #2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fafhrd91, thanks for your PR! By analyzing the history of the files in this pull request, we identified @1st1, @serhiy-storchaka and @misg to be potential reviewers. |
|
I fixed exceptions in tests suit which cause by previous PR seems some tests relies on specific behavior of |
Lib/asyncio/sslproto.py
Outdated
| def _on_shutdown_timeout(self): | ||
| if self._transport is not None: | ||
| self._fatal_error( | ||
| futures.TimeoutError(), 'Can not complete shitdown operation') |
|
@asvetlov care to work on this one too? |
|
Please push changenote into |
|
Close to favor of #4402 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.