bpo-42006: Stop using PyDict_GetItem, PyDict_GetItemString and _PyDict_GetItemId. #22648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
force-pushed
the
capi-dont-use-PyDict_GetItem
branch
from
0a805a7 to
e2cbee1
Compare
…t_GetItemId. These functions are considered not safe because they suppress all internal errors and can return wrong result. PyDict_GetItemString and _PyDict_GetItemId can also silence current exception in rare cases.
serhiy-storchaka
force-pushed
the
capi-dont-use-PyDict_GetItem
branch
from
e2cbee1 to
cd49ec3
Compare
serhiy-storchaka
requested review from
markshannon,
methane and
rhettinger
as code owners
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
…t_GetItemId. (pythonGH-22648) These functions are considered not safe because they suppress all internal errors and can return wrong result. PyDict_GetItemString and _PyDict_GetItemId can also silence current exception in rare cases. Remove no longer used _PyDict_GetItemId. Add _PyDict_ContainsId and rename _PyDict_Contains into _PyDict_Contains_KnownHash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions are considered not safe because they suppress all internal errors and can return wrong result.
PyDict_GetItemStringand_PyDict_GetItemIdcan also silence current exception in rare cases.https://bugs.python.org/issue42006