Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-5846: Deprecate obsolete methods makeSuite, findTestCases, and getTestCaseNames in unittest #20400

Closed
wants to merge 3 commits into from
Closed

bpo-5846: Deprecate obsolete methods makeSuite, findTestCases, and getTestCaseNames in unittest #20400

wants to merge 3 commits into from

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 25, 2020 •
edited
Loading

@erlend-aasland erlend-aasland requested review from berkerpeksag and a team as code owners May 25, 2020 21:56
Erlend E. Aasland added 3 commits November 17, 2020 23:02
@erlend-aasland erlend-aasland changed the title bpo-5846: Deprecate obsolete functions in unittest bpo-5846: Deprecate obsolete methods makeSuite, findTestCases, and getTestCaseNames in unittest Nov 18, 2020
@erlend-aasland erlend-aasland deleted the fix-issue-5846 branch September 12, 2021 19:06
@erlend-aasland erlend-aasland mentioned this pull request Sep 12, 2021
Merged
serhiy-storchaka
serhiy-storchaka reviewed Sep 12, 2021
View reviewed changes
Doc/library/unittest.rst Show resolved Hide resolved
Doc/whatsnew/3.10.rst Show resolved Hide resolved
Lib/test/support/__init__.py Show resolved Hide resolved
Lib/unittest/loader.py Show resolved Hide resolved
Lib/unittest/loader.py Show resolved Hide resolved
Lib/unittest/loader.py Show resolved Hide resolved
@erlend-aasland erlend-aasland mentioned this pull request Sep 12, 2021
Merged
@erlend-aasland
Copy link
Contributor Author

Thanks for reviewing, @serhiy-storchaka! As this was a very old PR, I was unable to change base to main and reopen it. I've opened GH-28299 instead. I'll apply your remarks there.

@voidspace voidspace mentioned this pull request May 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erlend-aasland @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot