-
-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-40447: accept all path-like objects in compileall.compile_file #19883
Changes from 1 commit
45af214
63d02ea
3dba07d
0426944
5d56bba
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
Accept :class:`pathlib.Path` in the ``ddir``, ``stripdir`` and ``prependdir`` | ||
arguments of :meth:`compileall.compile_file` and :meth:`compileall.compile_dir`. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This NEWS entry mentions There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think they already work, so we can just remove their mention from here. The original version of this PR had some more os.fspath, but that was unnecessary and removed because #19883 (comment) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree, their mention should be removed from the NEWS entry. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think you mean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ISTM it would be clearer to put the input normalization (
os.fspath()
) up above with the normalization offullname
andname
. I.e., add up above: