Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] bpo-22490: Remove __PYVENV_LAUNCHER__ from environment during launch (GH-9516) #19110

Merged
merged 1 commit into from
Mar 22, 2020

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Mar 22, 2020

  • bpo-22490: Remove "PYVENV_LAUNCHER" from the shell environment on macOS

This changeset removes the environment varialbe "PYVENV_LAUNCHER"
during interpreter launch as it is only needed to communicate between
the stub executable in framework installs and the actual interpreter.

Leaving the environment variable present may lead to misbehaviour when
launching other scripts.

  • Actually commit the changes for issue 22490...

  • Correct typo

Co-Authored-By: Nicola Soranzo [email protected]

  • Run make patchcheck

Co-authored-by: Jason R. Coombs [email protected]
Co-authored-by: Nicola Soranzo [email protected]
(cherry picked from commit 044cf94)

Co-authored-by: Ronald Oussoren [email protected]

https://bugs.python.org/issue22490

…ythonGH-9516)

* bpo-22490: Remove "__PYVENV_LAUNCHER__" from the shell environment on macOS

This changeset removes the environment varialbe "__PYVENV_LAUNCHER__"
during interpreter launch as it is only needed to communicate between
the stub executable in framework installs and the actual interpreter.

Leaving the environment variable present may lead to misbehaviour when
launching other scripts.

* Actually commit the changes for issue 22490...

* Correct typo

Co-Authored-By: Nicola Soranzo <[email protected]>

* Run make patchcheck

Co-authored-by: Jason R. Coombs <[email protected]>
Co-authored-by: Nicola Soranzo <[email protected]>
(cherry picked from commit 044cf94)

Co-authored-by: Ronald Oussoren <[email protected]>
@miss-islington
Copy link
Contributor Author

@ronaldoussoren and @jaraco: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@ronaldoussoren and @jaraco: Status check is done, and it's a success ✅ .

@jaraco jaraco merged commit c959fa9 into python:3.8 Mar 22, 2020
@miss-islington miss-islington deleted the backport-044cf94-3.8 branch March 22, 2020 18:56
@miss-islington
Copy link
Contributor Author

@ronaldoussoren and @jaraco: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants