Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-64383: Migrate builtins.vars and builtins.dir to Argument Clinic #18512

Closed
wants to merge 2 commits into from

Conversation

shihai1991
Copy link
Member

@shihai1991 shihai1991 commented Feb 15, 2020

@codecov
Copy link

codecov bot commented Feb 15, 2020

Codecov Report

Merging #18512 into master will increase coverage by 3.73%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #18512       +/-   ##
===========================================
+ Coverage   79.46%   83.20%    +3.73%     
===========================================
  Files         384     1571     +1187     
  Lines      169290   414730   +245440     
  Branches        0    44456    +44456     
===========================================
+ Hits       134529   345067   +210538     
- Misses      34761    60020    +25259     
- Partials        0     9643     +9643     
Impacted Files Coverage Δ
Python/dynload_shlib.c
Parser/parsetok.c
Python/marshal.c
Python/hamt.c
Python/clinic/sysmodule.c.h
Objects/bytes_methods.c
Modules/_hashopenssl.c
Modules/_ctypes/callbacks.c
Modules/cjkcodecs/cjkcodecs.h
Objects/capsule.c
... and 1943 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f632736...3b315ef. Read the comment docs.

@JelleZijlstra
Copy link
Member

Sorry this had to wait for so long! If you're still interested, would you be able to fix the merge conflicts? Then I can review it and get it merged.

@shihai1991
Copy link
Member Author

Sorry this had to wait for so long! If you're still interested, would you be able to fix the merge conflicts? Then I can review it and get it merged.

Oh, Thanks. Give me some time to take a look. I forget the details already :(

Copy link
Contributor

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for fixing the conflicts, as per above

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@arhadthedev arhadthedev changed the title bpo-20184: Migrate builtins.vars and builtins.dir to Argument Clinic gh-64383: Migrate builtins.vars and builtins.dir to Argument Clinic Feb 13, 2023
@arhadthedev arhadthedev added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Feb 13, 2023
@arhadthedev
Copy link
Member

Superseded by gh-100358.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting changes interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-argument-clinic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants