Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-30395: _PyGILState_Reinit deadlock fix #1734

Merged
merged 1 commit into from
May 22, 2017
Merged

Conversation

fried
Copy link
Contributor

@fried fried commented May 22, 2017

head_lock could be held by another thread when fork happened. We should
reset it to avoid deadlock.

head_lock could be held by another thread when fork happened. We should
reset it to avoid deadlock.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@fried
Copy link
Contributor Author

fried commented May 22, 2017

This is covered by corp CLA signed by Facebook. And I am upstream this internal patch.

Copy link
Member

@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@ambv ambv merged commit f82c951 into python:master May 22, 2017
ambv pushed a commit to ambv/cpython that referenced this pull request May 23, 2017
head_lock could be held by another thread when fork happened. We should
reset it to avoid deadlock.
(cherry picked from commit f82c951)
ambv added a commit that referenced this pull request May 23, 2017
head_lock could be held by another thread when fork happened. We should
reset it to avoid deadlock.
(cherry picked from commit f82c951)
@Mariatta
Copy link
Member

@fried has signed CLA, but @andriigrynenko (who made the commit) has not.

@fried fried deleted the bpo-30395 branch September 24, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants