Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-28556: Update the opening note in typing docs #16204

Merged
merged 2 commits into from
Sep 16, 2019

Conversation

ilevkivskyi
Copy link
Member

@ilevkivskyi ilevkivskyi commented Sep 16, 2019

This PR replaces the old note mentioning that typing is a provisional module with a new one mentioning types are not enforced at runtime. I am not sure if there was any official announcement about making typing non-provisional, but de-facto no new features were added during Python 3.7, and no backwards incompatible changes were made except for few small things that were considered bugs.

https://bugs.python.org/issue28556

:term:`provisional basis <provisional api>`. New features might
be added and API may change even between minor releases if deemed
necessary by the core developers.
Python runtime does not enforce the function and variable type annotations.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Python runtime does not enforce the function and ...

Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recall exactly how it became non-provisional, I think we already bent the rules for provisional modules by keeping it provisional longer than one release cycle. :-)

@ilevkivskyi ilevkivskyi merged commit 81528ba into python:master Sep 16, 2019
@ilevkivskyi ilevkivskyi deleted the update-typing-note branch September 16, 2019 22:04
@miss-islington
Copy link
Contributor

Thanks @ilevkivskyi for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 16, 2019
This PR replaces the old note mentioning that `typing` is a provisional module with a new one mentioning types are not enforced at runtime. I am not sure if there was any official announcement about making `typing` non-provisional, but _de-facto_ no new features were added during Python 3.7, and no backwards incompatible changes were made except for few small things that were considered bugs.
(cherry picked from commit 81528ba)

Co-authored-by: Ivan Levkivskyi <[email protected]>
@bedevere-bot
Copy link

GH-16205 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 16, 2019
This PR replaces the old note mentioning that `typing` is a provisional module with a new one mentioning types are not enforced at runtime. I am not sure if there was any official announcement about making `typing` non-provisional, but _de-facto_ no new features were added during Python 3.7, and no backwards incompatible changes were made except for few small things that were considered bugs.
(cherry picked from commit 81528ba)

Co-authored-by: Ivan Levkivskyi <[email protected]>
@bedevere-bot
Copy link

GH-16206 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Sep 16, 2019
This PR replaces the old note mentioning that `typing` is a provisional module with a new one mentioning types are not enforced at runtime. I am not sure if there was any official announcement about making `typing` non-provisional, but _de-facto_ no new features were added during Python 3.7, and no backwards incompatible changes were made except for few small things that were considered bugs.
(cherry picked from commit 81528ba)

Co-authored-by: Ivan Levkivskyi <[email protected]>
miss-islington added a commit that referenced this pull request Sep 16, 2019
This PR replaces the old note mentioning that `typing` is a provisional module with a new one mentioning types are not enforced at runtime. I am not sure if there was any official announcement about making `typing` non-provisional, but _de-facto_ no new features were added during Python 3.7, and no backwards incompatible changes were made except for few small things that were considered bugs.
(cherry picked from commit 81528ba)

Co-authored-by: Ivan Levkivskyi <[email protected]>
JelleZijlstra added a commit to python/peps that referenced this pull request May 1, 2021
PEP 484 is still marked as "Provisional", but as @Fidget-Spinner pointed out in python/typing#805, it shouldn't be any more. python/cpython#16204 removed talk about typing's provisional status from the module docs, and enhancements to typing have been in the form of new PEPs for the last few release cycles.

Going to mark this as a draft so Guido can have a chance to comment once he's back.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants