Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38132: Simplify _hashopenssl code #16023

Merged
merged 2 commits into from
Sep 12, 2019
Merged

bpo-38132: Simplify _hashopenssl code #16023

merged 2 commits into from
Sep 12, 2019

Conversation

tiran
Copy link
Member

@tiran tiran commented Sep 12, 2019 •
edited by bedevere-bot
Loading

Signed-off-by: Christian Heimes [email protected]

https://bugs.python.org/issue38132

@tiran tiran requested a review from gpshead September 12, 2019 10:52
gpshead
gpshead requested changes Sep 12, 2019
View reviewed changes
Copy link
Member

@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less code is better code! :)

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@gpshead gpshead self-assigned this Sep 12, 2019
@matrixise matrixise merged commit 5a4f82f into python:master Sep 12, 2019
@miss-islington
Copy link
Contributor

Thanks @tiran for the PR, and @matrixise for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 12, 2019
@tiran @miss-islington
bpo-38132: Simplify _hashopenssl code (pythonGH-16023)
e351b08 
Signed-off-by: Christian Heimes <[email protected]>
(cherry picked from commit 5a4f82f)

Co-authored-by: Christian Heimes <[email protected]>
@bedevere-bot
Copy link

GH-16040 is a backport of this pull request to the 3.8 branch.

@matrixise
Copy link
Member

Hi @tiran
Thanks for your PR.

matrixise pushed a commit that referenced this pull request Sep 12, 2019
@miss-islington @tiran @matrixise
bpo-38132: Simplify _hashopenssl code (GH-16023) (#16040)
67b90a0 
Signed-off-by: Christian Heimes <[email protected]>
(cherry picked from commit 5a4f82f)

Co-authored-by: Christian Heimes <[email protected]>
@manthey manthey mentioned this pull request Mar 4, 2020
Closed
@tiran tiran mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead approved these changes

Assignees

@gpshead gpshead

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tiran @bedevere-bot @miss-islington @matrixise @gpshead @the-knights-who-say-ni