Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] bpo-37972: unittest.mock._Call now passes on __getitem__ to the __getattr__ chaining so that call() can be subscriptable (GH-15565) #15965

Merged
merged 1 commit into from
Sep 12, 2019

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Sep 11, 2019

  • bpo-37972: unittest.mock._Call now passes on getitem to the getattr chaining so that call() can be subscriptable

  • 📜🤖 Added by blurb_it.

  • Update 2019-08-28-21-40-12.bpo-37972.kP-n4L.rst

added name of the contributor

  • bpo-37972: made all dunder methods chainable for _Call

  • bpo-37972: delegate only attributes of tuple instead to getattr
    (cherry picked from commit 72c3599)

Co-authored-by: blhsing [email protected]

https://bugs.python.org/issue37972

…attr__ chaining so that call() can be subscriptable (pythonGH-15565)

* bpo-37972: unittest.mock._Call now passes on __getitem__ to the __getattr__ chaining so that call() can be subscriptable

* 📜🤖 Added by blurb_it.

* Update 2019-08-28-21-40-12.bpo-37972.kP-n4L.rst

added name of the contributor

* bpo-37972: made all dunder methods chainable for _Call

* bpo-37972: delegate only attributes of tuple instead to __getattr__
(cherry picked from commit 72c3599)

Co-authored-by: blhsing <[email protected]>
Copy link
Contributor

@voidspace voidspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@voidspace voidspace merged commit db0d8a5 into python:3.8 Sep 12, 2019
@miss-islington miss-islington deleted the backport-72c3599-3.8 branch September 12, 2019 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants