bpo-25433: Align bytearray strip methods to those found in byteobject.c #14771
+75
−83
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to bpo-25433, knowledge about whitespace should be implemented only once.
bytearray.strip, .rstrip, .lstrip all had their own definitions of whitespace.
The implementations for
bytes
is cleaner and a also a little bit faster, so I adopted the code from there and modified it to work with bytearrays and to fulfil the documentation which states that for bytearrays these functions always return copies, even if no changes have been applied.I checked for performance regressions:
Current master:
Using this branch:
Timings using custom byte sequences to strip showed no differences at all between the two branches, no matter if one or multiple characters long.
https://bugs.python.org/issue25433