Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-37363: Document internal audit events #14663

Merged
merged 3 commits into from
Sep 12, 2019

Conversation

tiran
Copy link
Member

@tiran tiran commented Jul 9, 2019

Three internal cpython events were not documented, yet.

Signed-off-by: Christian Heimes [email protected]

https://bugs.python.org/issue37363

@tiran tiran added docs Documentation in the Doc dir skip news 🤖 automerge labels Jul 9, 2019
@tiran tiran requested a review from zooba July 9, 2019 10:32
@tiran tiran force-pushed the bpo-37363-cpython-events branch from cfe04e5 to 76ab18c Compare July 9, 2019 10:54
Copy link
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with modification

@@ -299,8 +299,9 @@ Initializing and finalizing the interpreter
than once; this can happen if an application calls :c:func:`Py_Initialize` and
:c:func:`Py_FinalizeEx` more than once.

.. versionadded:: 3.6
.. audit-event:: cpython._PySys_ClearAuditHooks "" c._PySys_ClearAuditHooks
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. audit-event:: cpython._PySys_ClearAuditHooks "" c._PySys_ClearAuditHooks
.. audit-event:: cpython._PySys_ClearAuditHooks "" c.Py_FinalizeEx

@zooba
Copy link
Member

zooba commented Jul 11, 2019

@tiran One more update and the this can be merged (I don't have permission to push the change to your branch myself)

@tiran tiran force-pushed the bpo-37363-cpython-events branch from f5c96a1 to 3d438db Compare September 11, 2019 14:44
@tiran tiran requested a review from zooba September 11, 2019 14:45
Copy link
Member

@matrixise matrixise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR, I have checked the result and the code. Everything seems to be correct.

@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 12, 2019
Three internal cpython events were not documented, yet.

Signed-off-by: Christian Heimes <[email protected]>

https://bugs.python.org/issue37363
(cherry picked from commit ed4b321)

Co-authored-by: Christian Heimes <[email protected]>
@bedevere-bot
Copy link

GH-16046 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Sep 12, 2019
Three internal cpython events were not documented, yet.

Signed-off-by: Christian Heimes <[email protected]>

https://bugs.python.org/issue37363
(cherry picked from commit ed4b321)

Co-authored-by: Christian Heimes <[email protected]>
@zooba zooba mentioned this pull request Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants