gh-127111: Emscripten Move link flags from LDFLAGS_NODIST to LINKFORSHARED
#127666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RED` The `-sEXPORTED_FUNCTIONS` setting will break when linking a shared library because the library doesn't `main` or `Py_Version` symbols. Only that one _needs_ to be moved, but most of these other flags are ignored when linking a shared library so it's better not to pass them. The only one that needs to be passed when linking shared libraries is `-sWASM_BIGINT` which changes the ABI.
hoodmane
changed the title
LDFLAGS_NODIST to LINKFORSHAREDLDFLAGS_NODIST to LINKFORSHARED
freakboy3742
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-sEXPORTED_FUNCTIONSsetting will break when linking a shared library because the library doesn'tmainorPy_Versionsymbols. Only that one needs to be moved, but most of these other flags are ignored when linking a shared library so it's better not to pass them. The only one that needs to be passed when linking shared libraries is-sWASM_BIGINTwhich changes the ABI.