gh-127503: Emscripten make Python.sh function as proper Python CLI #127506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mounts all native directories into the Emscripten file system except for dev, lib, and proc.
hoodmane
requested review from
brettcannon,
freakboy3742,
erlend-aasland and
corona10
as code owners
Useful for: --experimental flags, --inspect flags, etc.
hoodmane
commented
Dec 2, 2024
mdboom
approved these changes
Dec 2, 2024
|
Thanks for the review @mdboom! |
freakboy3742
requested changes
Dec 2, 2024
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Previous version only worked if the name was python.sh. If we symlink something else to it (say `python`) it would fail. This update makes it not depend on the name of the link.
freakboy3742
reviewed
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
realpath.python.shto mount all directories from the native file system except/dev,/liband/proc.allso that we can run tests in-tree. Now that Python can seepybuilddir.txtall of the paths work correctly running in-tree.node(for example to enable experimental features or debugging)Fixes #127503
Fixes #127111