gh-127321: Avoid stopping at an opcode without an associated line number for breakpoint() #127457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, @iritkatriel do you think we should backport this to 3.13? It's a bit of behavior change but only happens in rare cases. If not, we should protect all the access to |
|
I think this is a bug fix, so yes. |
|
Thanks @gaogaotiantian for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Sorry, @gaogaotiantian, I could not cleanly backport this to |
gaogaotiantian
added a commit
to gaogaotiantian/cpython
that referenced
this pull request
Dec 1, 2024
…ated line number for breakpoint() (pythonGH-127457) (cherry picked from commit 1bc4f07) Co-authored-by: Tian Gao <[email protected]>
|
GH-127487 is a backport of this pull request to the 3.13 branch. |
|
GH-127487 is a backport of this pull request to the 3.13 branch. |
gaogaotiantian
added a commit
that referenced
this pull request
Dec 1, 2024
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Dec 2, 2024
…ne number for breakpoint() (python#127457)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we are tracing opcodes (which only happen when we do
set_trace()for now), we just step instr again if there's no line number.f_trace_opcodestoTruecan lead tof_linenobeing removed in some cases (usingbreakpoint()/pdb.set_trace()) #127321