Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-127178: convert _sysconfigdata to a JSON file #127180

Closed
wants to merge 6 commits into from
Closed

GH-127178: convert _sysconfigdata to a JSON file #127180

wants to merge 6 commits into from

Conversation

FFY00
Copy link
Member

@FFY00 FFY00 commented Nov 22, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Nov 22, 2024
Open
@FFY00 FFY00 closed this Nov 26, 2024
@rgommers
Copy link

The change seems useful indeed. Is this PR closed by accident @FFY00, or for some other reason?

@FFY00
Copy link
Member Author

FFY00 commented Dec 10, 2024 •
edited
Loading

Converting the module itself to JSON turned out to be a bit problematic, so I pivoted to simply adding a JSON file with the sysconfig data in GH-127302. Though, in GH-127430, a followup to that PR, I fixed some of the issues I was running into earlier, so we may be able to revisit this PR.

@rgommers
Copy link

Thanks for the context!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Assignees
No one assigned
Labels
awaiting core review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FFY00 @rgommers