Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-126914: Use an atomic field for determining if the initial thread can be used #126915

Closed
wants to merge 8 commits into from
Closed

gh-126914: Use an atomic field for determining if the initial thread can be used #126915

wants to merge 8 commits into from
+46 −5

Conversation

ZeroIntensity
Copy link
Member

@ZeroIntensity ZeroIntensity commented Nov 16, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Nov 16, 2024
Closed
@ZeroIntensity ZeroIntensity changed the title gh-126914: Lock the runtime for longer during thread state deletion gh-126914: Lock the runtime for the entirety of thread state deletion Nov 16, 2024
@ZeroIntensity
Copy link
Member Author

QSBR seems to be breaking on free-threading for whatever reason :(

@ZeroIntensity ZeroIntensity marked this pull request as draft November 17, 2024 02:14
@ZeroIntensity ZeroIntensity changed the title gh-126914: Lock the runtime for the entirety of thread state deletion gh-126914: Use an atomic field for determining if the initial thread can be used Nov 17, 2024
@ZeroIntensity
Copy link
Member Author

Looks like the new fix works. Yay!

@ZeroIntensity ZeroIntensity marked this pull request as ready for review November 17, 2024 21:07
@ericsnowcurrently
Copy link
Member

While this solution makes sense, I have some thoughts on an alternate approach that will be better for us long-term. See gh-126989.

@ZeroIntensity ZeroIntensity mentioned this pull request Nov 19, 2024
Merged
@ZeroIntensity
Copy link
Member Author

Closing in favor of GH-126989

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees
No one assigned
Labels
awaiting review needs backport to 3.13 bugs and security fixes topic-subinterpreters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZeroIntensity @ericsnowcurrently