Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-126639: Add ResourceWarning to NamedTemporaryFile #126677

Merged
merged 11 commits into from
Dec 18, 2024
Merged

gh-126639: Add ResourceWarning to NamedTemporaryFile #126677

merged 11 commits into from
Dec 18, 2024

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Nov 11, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Nov 11, 2024
Closed
@graingert graingert force-pushed the add-warning-to-named-temporary-file branch from ae4b87b to 4932cd3 Compare November 11, 2024 08:05
@graingert
Copy link
Contributor Author

Ok this doesn't seem to break anything! I'll need to add a test though

@graingert graingert marked this pull request as ready for review November 11, 2024 08:20
graingert
graingert commented Nov 11, 2024
View reviewed changes
graingert
graingert commented Nov 11, 2024
View reviewed changes
@nineteendo
Copy link
Contributor

nineteendo commented Nov 11, 2024 •
edited
Loading

TIP: You can add suggestions to batch from the files tab to apply multiple suggestions in a single commit.

@graingert
Copy link
Contributor Author

TIP: You can add suggestions to batch from the files tab to apply multiple suggestions in a single commit.

Oh yeah I know, but I found the issues with some time apart so they didn't exist together to be batched

@kumaraditya303 kumaraditya303 enabled auto-merge (squash) December 18, 2024 08:22
@graingert
Copy link
Contributor Author

graingert commented Dec 18, 2024 •
edited
Loading

Now the question remains, is this a bugfix or a feature?

@kumaraditya303 kumaraditya303 merged commit bad3cde into python:main Dec 18, 2024
38 checks passed
@graingert graingert deleted the add-warning-to-named-temporary-file branch December 18, 2024 10:12
@kumaraditya303
Copy link
Contributor

I would treat it as feature, we don't add any new warnings in stable releases.

@graingert
Copy link
Contributor Author

Fair

srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@graingert @kumaraditya303 @srinivasreddy
pythongh-126639: Add ResourceWarning to NamedTemporaryFile (python#12…
6171ed1 
…6677)

Co-authored-by: Kumar Aditya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@graingert @nineteendo @kumaraditya303 @asvetlov