Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-121921: Update Lib/test/crashers #126360

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

gh-121921: Update Lib/test/crashers #126360

wants to merge 3 commits into from
+71 −58

Conversation

tomasr8
Copy link
Member

@tomasr8 tomasr8 commented Nov 3, 2024 •
edited by bedevere-app bot
Loading

mutation_inside_cyclegc.py and trace_at_recursion_limit.py do not crash anymore.
This PR moves them out of crashers and into unit tests to ensure they do not start crashing again.

@bedevere-app bedevere-app bot mentioned this pull request Nov 3, 2024
Open
@tomasr8
Copy link
Member Author

tomasr8 commented Nov 3, 2024

The gc crasher seems to hang and occasionally segfault on the FT build, I'll skip it for now and open a separate issue about it.

@tomasr8 tomasr8 mentioned this pull request Nov 3, 2024
Open
markshannon
markshannon requested changes Nov 8, 2024
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One confusing comment then fixing or removing. Otherwise LGTM.

Lib/test/test_sys_settrace.py Outdated
pass

def g(*args):
if True: # change to True to crash interpreter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment seems wrong.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does, but I copied it verbatim from the original crasher. I can remove it though if you prefer?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and removed the comment

@bedevere-app
Copy link

bedevere-app bot commented Nov 8, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@tomasr8
Copy link
Member Author

tomasr8 commented Nov 15, 2024

I have made the requested changes; please review again 🙂

@bedevere-app
Copy link

bedevere-app bot commented Nov 15, 2024

Thanks for making the requested changes!

@markshannon: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from markshannon November 15, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon Awaiting requested review from markshannon

Assignees
No one assigned
Labels
awaiting change review skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomasr8 @markshannon