-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-36345: Doc: make serve uses http.server instead of Tools/scripts/server.py #12408
Conversation
@JulienPalard here is the PR where we deprecate |
@vstinner should we write a version of Python in which this file should be removed in the message? This is not really a module, I don't think we should follow PEP 4, but I'd like to remove it slowly just in case someone found the file and though "hey let's use it!" @matrixise You have forgotten to remove serve.py from the Tools README, and to update make.bat. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
I have made the requested changes; please review again |
Thanks for making the requested changes! @vstinner: please review the changes made to this pull request. |
I have made the requested changes; please review again |
Thanks for making the requested changes! @vstinner: please review the changes made to this pull request. |
I added this PR #12511 |
Thanks for making the requested changes! @vstinner: please review the changes made to this pull request. |
@@ -0,0 +1,2 @@ | |||
Use :mod:`http.server` with ``-d`` parameter instead of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does "use http.server"? You should mention "make server" somewhere.
Hi @vstinner thank you for your review I have made the requested changes; please review again |
Thanks for making the requested changes! @vstinner: please review the changes made to this pull request. |
Please squash your commits into a single commit and update the PR title and description. It became very unclear what is the purpose of this change, because of its long history. |
|
https://bugs.python.org/issue36345