gh-120837: Update _Py_DumpExtensionModules to be async-signal-safe #121051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corona10
commented
Jun 26, 2024
Python/pylifecycle.c
Outdated
| PyMutex *mutex = &obj->ob_mutex; | ||
| uint8_t expected = _Py_UNLOCKED; | ||
| // Do not wake up other threads. | ||
| _Py_atomic_compare_exchange_uint8(&mutex->_bits, &expected, _Py_UNLOCKED); |
There was a problem hiding this comment.
Do we have to run for loop to prevent CAS failure?
There was a problem hiding this comment.
I think this should be a _Py_atomic_store_uint8(&mutex->_bits, _Py_UNLOCKED)
vstinner
reviewed
Jun 26, 2024
vstinner
reviewed
Jun 27, 2024
|
@colesbury PTAL :) |
colesbury
reviewed
Jun 27, 2024
Python/pylifecycle.c
Outdated
| PyMutex *mutex = &obj->ob_mutex; | ||
| uint8_t expected = _Py_UNLOCKED; | ||
| // Do not wake up other threads. | ||
| _Py_atomic_compare_exchange_uint8(&mutex->_bits, &expected, _Py_UNLOCKED); |
There was a problem hiding this comment.
I think this should be a _Py_atomic_store_uint8(&mutex->_bits, _Py_UNLOCKED)
colesbury
approved these changes
Jun 27, 2024
Python/pylifecycle.c
Outdated
Comment on lines
2922
to
2923
| #else | ||
| return; |
There was a problem hiding this comment.
The #else return; doesn't do anything. I would delete it, but up to you.
|
Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 27, 2024
…afe (pythongh-121051) (cherry picked from commit 1a2e7a7) Co-authored-by: Donghee Na <[email protected]>
|
GH-121107 is a backport of this pull request to the 3.13 branch. |
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
faulthandleritself crashes in free-threading build (in_Py_DumpExtensionModules) #120837