gh-120298: Fix use-after-free in list_richcompare_impl
#120303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, @serhiy-storchaka, you are correct. I simplified the reproduction to: class evil(object):
def __lt__(self, other):
other.clear()
return NotImplemented
a = [ [ evil()]]
a[0] < a # crash without this patchI've updated tests to store this test near |
Co-authored-by: Serhiy Storchaka <[email protected]>
sobolevn
added
needs backport to 3.12
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 11, 2024
…nGH-120303) (cherry picked from commit 141baba) Co-authored-by: Nikita Sobolev <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 11, 2024
…nGH-120303) (cherry picked from commit 141baba) Co-authored-by: Nikita Sobolev <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-120339 is a backport of this pull request to the 3.12 branch. |
|
GH-120340 is a backport of this pull request to the 3.13 branch. |
sobolevn
added a commit
that referenced
this pull request
Jun 11, 2024
…20303) (#120339) gh-120298: Fix use-after-free in `list_richcompare_impl` (GH-120303) (cherry picked from commit 141baba) Co-authored-by: Nikita Sobolev <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
sobolevn
added a commit
that referenced
this pull request
Jun 11, 2024
…20303) (#120340) gh-120298: Fix use-after-free in `list_richcompare_impl` (GH-120303) (cherry picked from commit 141baba) Co-authored-by: Nikita Sobolev <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
…n#120303) Co-authored-by: Serhiy Storchaka <[email protected]>
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
…n#120303) Co-authored-by: Serhiy Storchaka <[email protected]>
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…n#120303) Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code does the same thing as the code above it:
cpython/Objects/listobject.c
Lines 3360 to 3364 in 0ae8579
And looks like it gets the job done. I've added tests for these two corner cases.