gh-114053: Fix bad interaction of PEP-695, PEP-563 and get_type_hints
#118009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
AlexWaygood
commented
Apr 17, 2024
•
AlexWaygood
commented
- Issue: typing.get_type_hints fails when passed a class with PEP 695 type parameters and PEP 563 is enabled #114053
AlexWaygood
commented
Apr 17, 2024
Lib/typing.py
Outdated
| eval( | ||
| self.__forward_code__, | ||
| globalns, | ||
| {param.__name__: param for param in type_params} | localns |
There was a problem hiding this comment.
this means that any annotations in the "local namespace" of the class override any symbols that are present in the scope due to being listed as a type parameter. That matches the behaviour of __annotations__ at runtime in a module that doesn't use __future__ annotations:
>>> class B[T, *Ts, **P]:
... T = int
... Ts = str
... P = bytes
... x: T
... y: Ts
... z: P
...
>>> B.__annotations__
{'x': <class 'int'>, 'y': <class 'str'>, 'z': <class 'bytes'>}I'm doing it at the last possible point here as it feels less risky than doing it in _eval_type.
AlexWaygood
commented
Apr 17, 2024
Doc/library/typing.rst
Outdated
Comment on lines
3027
to
3029
| them in ``globals``, ``locals`` and (where applicable) | ||
| :ref:`type parameter <annotation-scopes>` namespaces. | ||
| For a class ``C``, return |
There was a problem hiding this comment.
we don't usually add .. versionchanged notes for bugfixes (and I think this is a bugfix), but I could add one if we think this is a significant enough change to the function's semantics
JelleZijlstra
approved these changes
Apr 19, 2024
Co-authored-by: Jelle Zijlstra <[email protected]>
|
Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Sorry, @AlexWaygood, I could not cleanly backport this to |
|
GH-118104 is a backport of this pull request to the 3.12 branch. |
AlexWaygood
added a commit
to AlexWaygood/cpython
that referenced
this pull request
Apr 19, 2024
…`get_type_hints`` (python#118009) (cherry-picked from commit 1e3e7ce) Co-authored-by: Jelle Zijlstra <[email protected]>
AlexWaygood
added a commit
that referenced
this pull request
Apr 19, 2024
…ype_hints`` (#118009) (#118104) Co-authored-by: Jelle Zijlstra <[email protected]>
1 task
vfazio
added a commit
to vfazio/pydantic
that referenced
this pull request
Jun 10, 2024
In CPython 3.12.4/3.13, the function signature of `FutureRef._evaluate` changed such that `recursive_guard` is no longer a positional argument; it is now keyword only [0][1]. To accomodate this, specify `recursive_guard` as a kwarg. This syntax is backwards compatible with earlier versions of the function signature. [0]: python/cpython#118104 [1]: python/cpython#118009 Signed-off-by: Vincent Fazio <[email protected]>
vfazio
added a commit
to vfazio/pydantic
that referenced
this pull request
Jun 10, 2024
In CPython 3.12.4/3.13, the function signature of `FutureRef._evaluate` changed such that `recursive_guard` is no longer a positional argument; it is now keyword only [0][1]. To accommodate this, specify `recursive_guard` as a kwarg. This syntax is backwards compatible with earlier versions of the function signature. [0]: python/cpython#118104 [1]: python/cpython#118009 Signed-off-by: Vincent Fazio <[email protected]>
5 tasks
alangenfeld
added a commit
to dagster-io/dagster
that referenced
this pull request
Jul 12, 2024
`recursive_guard` got made keyword arg only in python/cpython#118009 which released in `3.12.4` (we run an older version in buildkite so we missed it) fixes #22985 ## How I Tested These Changes on a fresh 3.12.4 venv `pytest python_modules/dagster/dagster_tests/general_tests/test_record.py python_modules/dagster/dagster_tests/general_tests/check_tests/test_check.py` which was failing before fix
|
cc for 3.12 backport: https://discuss.python.org/t/3-12-3-3-12-4-regression-deep-rabbit-hole-warning/59584/12 |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.