-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-76785: Add More Tests to test_interpreters.test_api #117662
gh-76785: Add More Tests to test_interpreters.test_api #117662
Conversation
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 9db5a2b 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
|
with self.subTest('main'): | ||
expected = _interpreters.new_config('legacy') | ||
expected.gil = 'own' | ||
interpid, *_ = _interpreters.get_main() | ||
config = _interpreters.get_config(interpid) | ||
self.assert_ns_equal(config, expected) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, this is a duplicate of the above subtest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is addressed in gh-117651. I'm fine with fixing it there since it's already done. 😄
gh-117662 introduced some refleaks, or, rather, exposed some existing refleaks. The leaks are coming when test.support.os_helper is imported in a "legacy" interpreter. I've updated test.test_interpreters.utils to avoid importing os_helper, which fixes the leaks. I'll address the root cause separately.
…h-117662) In addition to the increase test coverage, this is a precursor to sorting out how we handle interpreters created directly via the C-API.
…7913) pythongh-117662 introduced some refleaks, or, rather, exposed some existing refleaks. The leaks are coming when test.support.os_helper is imported in a "legacy" interpreter. I've updated test.test_interpreters.utils to avoid importing os_helper, which fixes the leaks. I'll address the root cause separately.
This is a precursor to sorting out how we handle interpreters created directly via the C-API.