gh-115167: Exclude vcruntime140_threads.dll with Visual Studio 2022 version 17.8 #115176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zooba
added
needs backport to 3.11
|
Thanks @adang1345 for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
Thanks! |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 8, 2024
…output (pythonGH-115176) (cherry picked from commit 5914a21) Co-authored-by: adang1345 <[email protected]>
|
GH-115186 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 8, 2024
…output (pythonGH-115176) (cherry picked from commit 5914a21) Co-authored-by: adang1345 <[email protected]>
|
GH-115187 is a backport of this pull request to the 3.11 branch. |
zooba
pushed a commit
that referenced
this pull request
Feb 8, 2024
…GH-115176) (cherry picked from commit 5914a21) Co-authored-by: adang1345 <[email protected]>
zooba
pushed a commit
that referenced
this pull request
Feb 8, 2024
…GH-115176) (cherry picked from commit 5914a21) Co-authored-by: adang1345 <[email protected]>
fsc-eriker
pushed a commit
to fsc-eriker/cpython
that referenced
this pull request
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visual Studio 2022 version 17.8 introduced support for C11 threads, provided by
vcruntime140_threads.dll. When building locally withTools\msi\buildrelease.batusing this Visual Studio version, avoid vendoringvcruntime140_threads.dllin the Python distribution.