gh-114099: Add test exclusions to support running the test suite on iOS #114889

freakboy3742 · 2024-02-02T05:28:57Z

Part of the PEP 730 work to add iOS support.

Adds test annotations required to run the CPython test suite on iOS.

The majority of these changes involve:

Annotating tests that use subprocess, but are skipped on Emscripten/WASI for other reasons
Including iOS/tvOS/watchOS under the same umbrella as macOS/darwin checks

is_apple and is_apple_mobile test helpers have been added to identify any Apple platform, and "any Apple platform except macOS", respectively.

Refs #114099.

Issue: Add support for iOS as a target platform #114099

erlend-aasland

Thanks, looks good to me!

Lib/test/support/__init__.py

Lib/test/test_asyncio/test_events.py

Lib/test/test_asyncio/test_unix_events.py

Lib/test/test_pty.py

Lib/test/test_venv.py

mhsmith · 2024-02-04T11:19:23Z

I'm not a project member, so I can't resolve my conversations, but they've all now been addressed.

willingc

Looks good. Ran without issue on Sonoma 14.2.1. One small question/nit re: an import.
🚢

willingc · 2024-02-04T19:41:08Z

Lib/test/test_asyncio/test_unix_events.py

@@ -1874,7 +1874,7 @@ async def runner():
            wsock.close()


-@unittest.skipUnless(hasattr(os, 'fork'), 'requires os.fork()')
+@support.requires_fork()


Nice. Much cleaner.

willingc · 2024-02-04T19:58:08Z

Lib/test/test_code_module.py

@@ -160,6 +161,7 @@ def setUp(self):
        self.console = code.InteractiveConsole(local_exit=True)
        self.mock_sys()

+    @unittest.skipIf(sys.flags.no_site, "exit() isn't defined unless there's a site module")


Does this work if the import site does not exist in the file?

It does - the import site was a leftover from a previous attempt to fix the problem that was ultimately resolved with the no_site-based skip. I've removed the import.

erlend-aasland · 2024-02-04T23:32:24Z

Are you ready to land this, @freakboy3742?

freakboy3742 · 2024-02-04T23:38:21Z

@erlend-aasland I'm ready if everyone else is :-)

erlend-aasland · 2024-02-05T00:00:40Z

AFAICS, @willingc's remarks have been addressed; the rest are thumbs up. Let's go :)

…e on iOS (python#114889) Add test annotations required to run the test suite on iOS (PEP 730). The majority of the change involve annotating tests that use subprocess, but are skipped on Emscripten/WASI for other reasons, and including iOS/tvOS/watchOS under the same umbrella as macOS/darwin checks. `is_apple` and `is_apple_mobile` test helpers have been added to identify *any* Apple platform, and "any Apple platform except macOS", respectively.

encukou · 2024-03-04T16:06:29Z

Lib/test/test_fcntl.py

+from test.support import (
+    cpython_only, get_pagesize, is_apple, requires_subprocess, verbose
+)


You seem to do this change often. In the future, could you add a trailing comma, to make future diffs nicer?
(Or simply add another line if the current one gets too long:

from test.support import verbose, cpython_only, get_pagesize from test.support import is_apple, requires_subprocess

)

@encukou Sure, no problem.

One of the issues I've hit is that the "preferred" style for imports varies wildly between files. I appreciate there's 30 years of historical baggage in the existing code - but is there a reason either of those two approaches is preferred over isort/black style syntax:

from test.support import ( cpython_only, get_pagesize, is_apple, requires_subprocess, verbose, )

Running black over every file I touch would make for unreadable patches; but if little black touches when the line is already being altered would be looked on favourably, then that's an easy tweak to make.

That works too -- there's a trailing comma, so future diffs won't need to add it.

(The 30 years of baggage also means there is no shared preference for stuff that isn't in PEP 8. I'm partial to repeating from <name> because it's searchable with grep -- you don't need a code analyzer -- but that's just personal opinion.)

if little black touches when the line is already being altered would be looked on favourably

Sure! As long as it helps readability :)

…st suite on iOS (python#114889) Add test annotations required to run the test suite on iOS (PEP 730). The majority of the change involve annotating tests that use subprocess, but are skipped on Emscripten/WASI for other reasons, and including iOS/tvOS/watchOS under the same umbrella as macOS/darwin checks. `is_apple` and `is_apple_mobile` test helpers have been added to identify *any* Apple platform, and "any Apple platform except macOS", respectively.

…t suite on iOS (python#114889) Add test annotations required to run the test suite on iOS (PEP 730). The majority of the change involve annotating tests that use subprocess, but are skipped on Emscripten/WASI for other reasons, and including iOS/tvOS/watchOS under the same umbrella as macOS/darwin checks. `is_apple` and `is_apple_mobile` test helpers have been added to identify *any* Apple platform, and "any Apple platform except macOS", respectively.

…st suite on iOS (python#114889) Add test annotations required to run the test suite on iOS (PEP 730). The majority of the change involve annotating tests that use subprocess, but are skipped on Emscripten/WASI for other reasons, and including iOS/tvOS/watchOS under the same umbrella as macOS/darwin checks. `is_apple` and `is_apple_mobile` test helpers have been added to identify *any* Apple platform, and "any Apple platform except macOS", respectively.

…t suite on iOS (python#114889) Add test annotations required to run the test suite on iOS (PEP 730). The majority of the change involve annotating tests that use subprocess, but are skipped on Emscripten/WASI for other reasons, and including iOS/tvOS/watchOS under the same umbrella as macOS/darwin checks. `is_apple` and `is_apple_mobile` test helpers have been added to identify *any* Apple platform, and "any Apple platform except macOS", respectively.

…st suite on iOS (python#114889) Add test annotations required to run the test suite on iOS (PEP 730). The majority of the change involve annotating tests that use subprocess, but are skipped on Emscripten/WASI for other reasons, and including iOS/tvOS/watchOS under the same umbrella as macOS/darwin checks. `is_apple` and `is_apple_mobile` test helpers have been added to identify *any* Apple platform, and "any Apple platform except macOS", respectively.

…t suite on iOS (python#114889) Add test annotations required to run the test suite on iOS (PEP 730). The majority of the change involve annotating tests that use subprocess, but are skipped on Emscripten/WASI for other reasons, and including iOS/tvOS/watchOS under the same umbrella as macOS/darwin checks. `is_apple` and `is_apple_mobile` test helpers have been added to identify *any* Apple platform, and "any Apple platform except macOS", respectively.

…st suite on iOS (python#114889) Add test annotations required to run the test suite on iOS (PEP 730). The majority of the change involve annotating tests that use subprocess, but are skipped on Emscripten/WASI for other reasons, and including iOS/tvOS/watchOS under the same umbrella as macOS/darwin checks. `is_apple` and `is_apple_mobile` test helpers have been added to identify *any* Apple platform, and "any Apple platform except macOS", respectively.

Add test exclusions to support running the test suite on iOS.

3f83f4c

freakboy3742 requested review from berkerpeksag, erlend-aasland, vsajip, 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners February 2, 2024 05:28

bedevere-app bot added the awaiting review label Feb 2, 2024

bedevere-app bot mentioned this pull request Feb 2, 2024

Add support for iOS as a target platform #114099

Closed

freakboy3742 added 2 commits February 2, 2024 13:29

Merge branch 'main' into iOS-test-skips

490b8b1

Make sure you save all the files before submitting a PR...

a38e92b

erlend-aasland approved these changes Feb 2, 2024

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting review labels Feb 2, 2024

mhsmith reviewed Feb 2, 2024

View reviewed changes

freakboy3742 added 2 commits February 3, 2024 08:37

Clarified some test exclusions.

74803b1

Simplified logical expression of platform groupings.

86cbced

mhsmith approved these changes Feb 4, 2024

View reviewed changes

willingc approved these changes Feb 4, 2024

View reviewed changes

Removed unnecessary import.

bc7543b

erlend-aasland self-assigned this Feb 4, 2024

erlend-aasland merged commit 391659b into python:main Feb 5, 2024
31 checks passed

bedevere-app bot removed the awaiting merge label Feb 5, 2024

freakboy3742 deleted the iOS-test-skips branch February 5, 2024 00:16

mhsmith mentioned this pull request Feb 25, 2024

gh-71052: Add test exclusions to support running the test suite on Android #115918

Merged

encukou reviewed Mar 4, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gh-114099: Add test exclusions to support running the test suite on iOS #114889

gh-114099: Add test exclusions to support running the test suite on iOS #114889

freakboy3742 commented Feb 2, 2024 •

edited by bedevere-app bot

Loading

erlend-aasland left a comment

mhsmith commented Feb 4, 2024

willingc left a comment

willingc Feb 4, 2024

willingc Feb 4, 2024

freakboy3742 Feb 4, 2024

erlend-aasland commented Feb 4, 2024

freakboy3742 commented Feb 4, 2024

erlend-aasland commented Feb 5, 2024

encukou Mar 4, 2024

freakboy3742 Mar 4, 2024

encukou Mar 6, 2024

gh-114099: Add test exclusions to support running the test suite on iOS #114889

gh-114099: Add test exclusions to support running the test suite on iOS #114889

Conversation

freakboy3742 commented Feb 2, 2024 • edited by bedevere-app bot Loading

erlend-aasland left a comment

Choose a reason for hiding this comment

mhsmith commented Feb 4, 2024

willingc left a comment

Choose a reason for hiding this comment

willingc Feb 4, 2024

Choose a reason for hiding this comment

willingc Feb 4, 2024

Choose a reason for hiding this comment

freakboy3742 Feb 4, 2024

Choose a reason for hiding this comment

erlend-aasland commented Feb 4, 2024

freakboy3742 commented Feb 4, 2024

erlend-aasland commented Feb 5, 2024

encukou Mar 4, 2024

Choose a reason for hiding this comment

freakboy3742 Mar 4, 2024

Choose a reason for hiding this comment

encukou Mar 6, 2024

Choose a reason for hiding this comment

freakboy3742 commented Feb 2, 2024 •

edited by bedevere-app bot

Loading