Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-35685: Add examples of unittest.mock.patch.dict usage #11456

Merged
merged 9 commits into from
Sep 12, 2019
Merged

bpo-35685: Add examples of unittest.mock.patch.dict usage #11456

merged 9 commits into from
Sep 12, 2019

Conversation

eamanu
Copy link
Contributor

@eamanu eamanu commented Jan 7, 2019 •
edited by bedevere-bot
Loading

Add examples of the use of mock.path.dict with decorator and in class. Currently there are examples only with the use on context manager.

https://bugs.python.org/issue35685

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jan 7, 2019
@eamanu
Copy link
Contributor Author

eamanu commented Jan 7, 2019 •
edited
Loading

ping @terryjreedy :-) could you review this? thanks

tirkarthi
tirkarthi reviewed Jan 7, 2019
View reviewed changes
@terryjreedy
Copy link
Member

Tracker issues are more visible than PRs and more likely to get the attention of a core dev who can review and merge. Michael Foord is the listed expert for unittest.mock, but does not have a listed GitHub account and therefore is inactive. I am not an expert on either unittest or rst and have a backlog of IDLE PRs to review, so I will have to pass.

@eamanu
Copy link
Contributor Author

eamanu commented Jan 8, 2019

Tracker issues are more visible than PRs and more likely to get the attention of a core dev who can review and merge. Michael Foord is the listed expert for unittest.mock, but does not have a listed GitHub account and therefore is inactive. I am not an expert on either unittest or rst and have a backlog of IDLE PRs to review, so I will have to pass.

Thanks for the response. I will open a issue on bugs.python

@eamanu eamanu changed the title Doc: Add samples on patch.dict of the use of decorator and in class bpo-35685: Add samples on patch.dict of the use of decorator and in class Jan 8, 2019
berkerpeksag
berkerpeksag requested changes Jan 9, 2019
View reviewed changes
Copy link
Member

@berkerpeksag berkerpeksag left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for wanting to improve our documentation! :) I just left some comments.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@eamanu
Copy link
Contributor Author

eamanu commented Jan 9, 2019

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@berkerpeksag: please review the changes made to this pull request.

berkerpeksag
berkerpeksag previously requested changes Jan 10, 2019
View reviewed changes
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@eamanu
Copy link
Contributor Author

eamanu commented Jan 10, 2019

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@berkerpeksag: please review the changes made to this pull request.

@merwok merwok changed the title bpo-35685: Add samples on patch.dict of the use of decorator and in class bpo-35685: Add examples of unittest.mock.patch.dict usage Jan 11, 2019
@eamanu
Copy link
Contributor Author

eamanu commented Jan 31, 2019

ping @berkerpeksag :-)

@csabella csabella requested a review from berkerpeksag June 5, 2019 23:26
@eamanu
Copy link
Contributor Author

eamanu commented Sep 12, 2019

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@berkerpeksag, @JulienPalard: please review the changes made to this pull request.

@JulienPalard
Copy link
Member

I rebased on top of master because another commit (0453081) introduced a versionchanged that would be misplaced if I let github merge it.

@JulienPalard JulienPalard dismissed berkerpeksag’s stale review September 12, 2019 11:27

Changes has been applied

@JulienPalard JulienPalard merged commit 31a82e2 into python:master Sep 12, 2019
@miss-islington
Copy link
Contributor

Thanks @eamanu for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 12, 2019
@eamanu @miss-islington
bpo-35685: Add examples of unittest.mock.patch.dict usage (pythonGH-1…
da361f9 
…1456)

(cherry picked from commit 31a82e2)

Co-authored-by: Emmanuel Arias <[email protected]>
@bedevere-bot
Copy link

GH-16031 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Sep 12, 2019
@miss-islington @eamanu
bpo-35685: Add examples of unittest.mock.patch.dict usage (GH-11456)
648494b 
(cherry picked from commit 31a82e2)

Co-authored-by: Emmanuel Arias <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirkarthi tirkarthi tirkarthi left review comments

@berkerpeksag berkerpeksag berkerpeksag approved these changes

@JulienPalard JulienPalard JulienPalard approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@eamanu @terryjreedy @bedevere-bot @JulienPalard @miss-islington @berkerpeksag @tirkarthi @the-knights-who-say-ni