-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-112713 : Add support for 'partitioned' attribute in http.cookies #112714
Merged
gpshead
merged 22 commits into
python:main
from
giles-v:add-cookies-partitioned-support
Jan 24, 2025
+28
−1
Merged
Changes from 9 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
5901f2e
Add support for 'partitioned' attribute in http.cookies
a6fe17a
Merge branch 'main' into add-cookies-partitioned-support
giles-v 9175076
📜🤖 Added by blurb_it.
blurb-it[bot] f20ba61
Fix invalid test name function
20ac30d
Merge branch 'main' into add-cookies-partitioned-support
gpshead 1482ed7
Merge branch 'main' into add-cookies-partitioned-support
gpshead 80df6e7
Wordsmith the docs and include a link to the spec.
gpshead 21cf60e
Style: Don't retain unusual hand spacing.
gpshead b1f7cbd
News ReST improvements.
gpshead f6391d6
Add support for 'partitioned' attribute in http.cookies
14d9a5c
📜🤖 Added by blurb_it.
blurb-it[bot] e622cda
Fix invalid test name function
1949596
Wordsmith the docs and include a link to the spec.
gpshead 9f3c9b0
Style: Don't retain unusual hand spacing.
gpshead f03bdd9
News ReST improvements.
gpshead 097fc45
Remove Path=/ mandatory requirement from the docs
de432da
Pull changes
c564125
Merge branch 'main' into add-cookies-partitioned-support
giles-v 4fdecb5
Move morsel docs version to 3.1.4, and revert spacing changes
7dc5110
Merge upstream/main
bb95c15
Merge branch 'main' into add-cookies-partitioned-support
giles-v e9363fb
Merge branch 'main' into add-cookies-partitioned-support
giles-v File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
Misc/NEWS.d/next/Core and Builtins/2023-12-04-15-53-25.gh-issue-112713.Zrhv77.rst
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Added support for the ``Partitioned`` cookie flag in :mod:`http.cookies`. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the wording here to clarify that Secure is required... but the CHIPS spec doesn't explicitly say anything about Path= though Path=/ appears in all of its examples. What wording should be used regarding Path, I'm not sure how I've phrased this is wholly accurate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per privacycg/CHIPS#49,
Path=/
is not needed. I'm going to push an update to this PR shortly.