bpo-35325:imp.find_module() return value documentation discrepancy #11040
Conversation
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
You will want to add a NEWS entry. The "blurb" tool makes this easy. See the devguide for more info. Please be sure to add yourself to Misc/ACKS (in this PR) if you aren't there already. |
|
I removed the " needs backport to 3.6" label, the 3.6 branch no long accept bugfixes (only security fixes are accepted): https://devguide.python.org/#status-of-python-branches |
|
I updated the PR based on @ericsnowcurrently 's review. Thank you. |
|
Thanks @Windsooon for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
…ncy (pythonGH-11040) (cherry picked from commit 967b84c) Co-authored-by: Windson yang <[email protected]>
|
GH-16035 is a backport of this pull request to the 3.8 branch. |
|
GH-16036 is a backport of this pull request to the 3.7 branch. |
…ncy (pythonGH-11040) (cherry picked from commit 967b84c) Co-authored-by: Windson yang <[email protected]>
…ncy (GH-11040) (cherry picked from commit 967b84c) Co-authored-by: Windson yang <[email protected]>
…ncy (GH-11040) (cherry picked from commit 967b84c) Co-authored-by: Windson yang <[email protected]>
I'm not sure we should keep the change in Doc/library/imp.rst, feel free to edit it.
https://bugs.python.org/issue35325