Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-103053: Run tools test_freeze on buildbot #110075

Closed
wants to merge 6 commits into from

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Sep 29, 2023

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @vstinner for commit ff148fe 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 29, 2023
@vstinner
Copy link
Member Author

Oh, test_tools fails on FreeBSD: https://buildbot.python.org/all/#/builders/1228/builds/8

--- pybuilddir.txt ---
./python -E -S -m sysconfig --generate-posix-vars ; if test $? -ne 0 ; then  echo "generate-posix-vars failed" ;  rm -f ./pybuilddir.txt ;  exit 1 ;  fi
sh: ./python: not found
*** [pybuilddir.txt] Error code 127

@vstinner
Copy link
Member Author

!buildbot AMD64 FreeBSD PR

@vstinner
Copy link
Member Author

Windows x64 failed: issue gh-109878:

FAIL: test_wait_for_timeout_less_then_0_or_0 (test.test_asyncio.test_waitfor.AsyncioWaitForTest.test_wait_for_timeout_less_then_0_or_0) (timeout=-1)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\cpython\cpython\Lib\test\test_asyncio\test_waitfor.py", line 124, in test_wait_for_timeout_less_then_0_or_0
    self.assertLess(t1 - t0, 0.1)
AssertionError: 0.10999999999989996 not less than 0.1

@vstinner vstinner marked this pull request as draft September 29, 2023 09:19
@vstinner vstinner added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 29, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @vstinner for commit da55dc2 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 29, 2023
@vstinner
Copy link
Member Author

!buildbot AMD64 FreeBSD PR

2 similar comments
@vstinner
Copy link
Member Author

!buildbot AMD64 FreeBSD PR

@vstinner
Copy link
Member Author

!buildbot AMD64 FreeBSD PR

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @vstinner for commit 742381c 🤖

The command will test the builders whose names match following regular expression: AMD64 FreeBSD PR

The builders matched are:

  • AMD64 FreeBSD PR

@vstinner
Copy link
Member Author

!buildbot AMD64 FreeBSD PR

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @vstinner for commit 13eee42 🤖

The command will test the builders whose names match following regular expression: AMD64 FreeBSD PR

The builders matched are:

  • AMD64 FreeBSD PR

@vstinner
Copy link
Member Author

!buildbot AMD64 FreeBSD PR

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @vstinner for commit 39424ce 🤖

The command will test the builders whose names match following regular expression: AMD64 FreeBSD PR

The builders matched are:

  • AMD64 FreeBSD PR

@vstinner
Copy link
Member Author

Oh, test_tools fails on FreeBSD

The problem is this code in Makefile.pre.in:

$(BUILDPYTHON):	Programs/python.o $(LINK_PYTHON_DEPS)
	$(LINKCC) $(PY_CORE_LDFLAGS) $(LINKFORSHARED) -o $@ Programs/python.o $(LINK_PYTHON_OBJS) $(LIBS) $(MODLIBS) $(SYSLIBS)

On the buildbot, we have:

  • $(BUILDPYTHON) = python
  • $@ = /tmp/test_python_7mxk6_9f/tmpxcjgcgeh/cpython/python

The problem is that /tmp/test_python_7mxk6_9f/tmpxcjgcgeh/cpython is the source directory, not the build directory: /tmp/test_python_7mxk6_9f/tmpxcjgcgeh/python-build.

I'm not sure why FreeBSD make creates an absolute path to the source directory, instead of the build directory.

For me, $(BUILDPYTHON) = python is the correct behavior. The question is more to know how to generate a gcc -o value which is in the right directory.

Note: on my FreeBSD 13 VM, I don't get this behavior when I build Python out of tree. It works the same as Linux make: $@ is just python.

@vstinner
Copy link
Member Author

vstinner commented Oct 5, 2023

!buildbot AMD64 FreeBSD PR

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @vstinner for commit 32d95c9 🤖

The command will test the builders whose names match following regular expression: AMD64 FreeBSD PR

The builders matched are:

  • AMD64 FreeBSD PR

@vstinner
Copy link
Member Author

vstinner commented Oct 5, 2023

!buildbot AMD64 FreeBSD PR

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @vstinner for commit 32d95c9 🤖

The command will test the builders whose names match following regular expression: AMD64 FreeBSD PR

The builders matched are:

  • AMD64 FreeBSD PR

@vstinner
Copy link
Member Author

vstinner commented Oct 6, 2023

I wrote real fixes: PR #110451 and PR #110449.

@vstinner vstinner closed this Oct 6, 2023
@vstinner vstinner deleted the freeze_buildbot branch October 6, 2023 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants