Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-76785: Use Pending Calls When Releasing Cross-Interpreter Data #109556

Merged
merged 11 commits into from
Sep 19, 2023

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Sep 18, 2023

This fixes some crashes in the _xxinterpchannels module, due to a race between interpreters.

(Backporting this to 3.12 will have to be done in a way that does not introduce the new _PyCrossInterpreterData_ReleaseAndRawFree() into the public ABI.)

@ericsnowcurrently ericsnowcurrently merged commit fd7e08a into python:main Sep 19, 2023
@miss-islington
Copy link
Contributor

Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@ericsnowcurrently ericsnowcurrently deleted the fix-channels branch September 19, 2023 21:01
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 19, 2023
…ta (pythongh-109556)

This fixes some crashes in the _xxinterpchannels module, due to a race between interpreters.
(cherry picked from commit fd7e08a)

Co-authored-by: Eric Snow <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 19, 2023

GH-109586 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Sep 19, 2023
@bedevere-bot

This comment was marked as off-topic.

@bedevere-bot

This comment was marked as off-topic.

@bedevere-bot

This comment was marked as off-topic.

@bedevere-bot

This comment was marked as off-topic.

csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
…ta (pythongh-109556)

This fixes some crashes in the _xxinterpchannels module, due to a race between interpreters.
ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull request Oct 12, 2023
…ta (pythongh-109556)

This fixes some crashes in the _xxinterpchannels module, due to a race between interpreters.
(cherry picked from commit fd7e08a)

Co-authored-by: Eric Snow <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Nov 20, 2023

GH-112288 is a backport of this pull request to the 3.12 branch.

ericsnowcurrently added a commit that referenced this pull request Nov 27, 2023
…ata (gh-109556) (gh-112288)

This fixes some crashes in the _xxinterpchannels module, due to a race between interpreters.
(cherry picked from commit fd7e08a)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
…ta (pythongh-109556)

This fixes some crashes in the _xxinterpchannels module, due to a race between interpreters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants