-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-109409: Fix inheritance of frozen dataclass from non-frozen dataclass mixins #109437
Conversation
sobolevn
commented
Sep 15, 2023
•
edited by bedevere-app
bot
Loading
edited by bedevere-app
bot
- Issue: frozen dataclass inheritance is not strictly checked in multiple inheritance #109409
I've added this to my list of things to do during the core dev sprint in October. I'll review it then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks!
@sobolevn : I can't merge because your branch is out of date. Can you merge from main? Then I'll accept this.
I could probably do it myself, but I don't know the implications for the PR, so it's probably best if you do it.
|
…dataclass mixins (pythongh-109437) Fix inheritance of frozen dataclass from non-frozen dataclass mixins