Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-92584: Redirect to Setuptools' guidance on extension modules #108030

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Aug 16, 2023

I'm unsure if we should just drop extending/windows entirely, as it internally reccomends just to use setuptools:

Module authors are encouraged to use the distutils approach for building extension modules, instead of the one described in this section.

A


📚 Documentation preview 📚: https://cpython-previews--108030.org.readthedocs.build/

@zooba
Copy link
Member

zooba commented Aug 16, 2023

I'm unsure if we should just drop extending/windows entirely

It's got important information in there that probably doesn't officially exist anywhere else, and for POSIX devs trying to make stuff work on Windows I'm sure it's invaluable (though it would be nice to have similar guides for Windows devs trying to make stuff work on *nix, but I'm not going to hold my breath). Expecting people to extract the same information from setuptools or another backend is asking too much.

That said, it's in desperate need of cleanup and modernisation anyway, so I won't miss it. A cross-platform primer on building extension modules by hand (i.e. without setuptools), referencing sysconfig heavily I'd expect, would be a great replacement.

@AA-Turner
Copy link
Member Author

A cross-platform primer on building extension modules by hand (i.e. without setuptools), referencing sysconfig heavily I'd expect, would be a great replacement.

Should we open a new issue for this?

A

@zooba
Copy link
Member

zooba commented Aug 16, 2023

Should we open a new issue for this?

It won't hurt, but I'm not sure it'll help convince anyone to actually do it. But I don't know of any better place to put the note - maybe as a comment in the docs as well (referencing the soon-to-be-created new issue)?

@AA-Turner
Copy link
Member Author

Opened #108064

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review docs Documentation in the Doc dir needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes skip news
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

4 participants