Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-92584: Remove distutils mentions from importlib.metadata docs #108026

Closed

Conversation

AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Aug 16, 2023

eps.groups returns a set, so I've also changed the return type.

A


📚 Documentation preview 📚: https://cpython-previews--108026.org.readthedocs.build/

@AA-Turner AA-Turner added docs Documentation in the Doc dir skip news needs backport to 3.12 bug and security fixes labels Aug 16, 2023
@AA-Turner AA-Turner requested a review from jaraco August 16, 2023 14:23
@AlexWaygood AlexWaygood changed the title GH-92584: Remove distutils from importlib.metadata GH-92584: Remove distutils mentions from importlib.metadata docs Aug 16, 2023
Copy link
Member

@jaraco jaraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contrib, but I'm reluctant to accept this change for a few reasons.

First, these docs changes originate in the importlib_metadata project, so probably should be contributed there first. They get synced into CPython as a matter of course, but contributing here first leads to conflicts and is more difficult to backport.

Second, the distutils.commands entry point is just as viable as console_scripts. Both are still actively supported by Setuptools, even while distutils is removed from the stdlib. There are no plans currently to even deprecate distutils.commands, so the value here is small.

Given my concerns with the changes, I propose instead to open an issue with importlib_metadata describing the motivation for making changes and then propose a change there.

Thanks.

Doc/library/importlib.metadata.rst Show resolved Hide resolved
Doc/library/importlib.metadata.rst Show resolved Hide resolved
@jaraco jaraco closed this Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge docs Documentation in the Doc dir needs backport to 3.12 bug and security fixes skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants