Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-106004: PyDict_GetItemRef() should only be in the limited API 3.13 #107229

Merged

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jul 25, 2023

Include/dictobject.h Outdated Show resolved Hide resolved
@vstinner
Copy link
Member

Oh sorry, I always forget to pay attention to versionning when adding a function to the limited C API.

@serhiy-storchaka serhiy-storchaka changed the title gh-106004: PyDict_GetItemRef() should only be in the limited API 3.13 gh-106004: PyDict_GetItemRef() should only be in the limited API 3.10 Jul 25, 2023
@serhiy-storchaka serhiy-storchaka changed the title gh-106004: PyDict_GetItemRef() should only be in the limited API 3.10 gh-106004: PyDict_GetItemRef() should only be in the limited API 3.13 Jul 25, 2023
@serhiy-storchaka serhiy-storchaka force-pushed the limited-capi-PyDict_GetItemRef branch from 4210c15 to 6730eec Compare July 25, 2023 11:07
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@serhiy-storchaka serhiy-storchaka merged commit 2b1a81e into python:main Jul 25, 2023
@serhiy-storchaka serhiy-storchaka deleted the limited-capi-PyDict_GetItemRef branch July 25, 2023 18:48
jtcave pushed a commit to jtcave/cpython that referenced this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants