Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-105751, test_ctypes: Remove disabled tests #105826

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jun 15, 2023

  • The following tests were disabled since the initial ctypes commit in 2006, commit babddfc:

    • Callbacks.test_char_p()
    • DeletePointerTestCase.test_X()
    • NumberTestCase.test_perf()
    • StructureTestCase.test_subclass_creation()
    • Tests.test_X() of test_byteswap
  • NumberTestCase.test_bool_from_address() was disabled in 2007 by commit 5dc4fe0.

  • Remove check_perf() and run_test() of test_numbers.

* The following tests were disabled since the initial ctypes commit
  in 2006, commit babddfc:

  * Callbacks.test_char_p()
  * DeletePointerTestCase.test_X()
  * NumberTestCase.test_perf()
  * StructureTestCase.test_subclass_creation()
  * Tests.test_X() of test_byteswap

* NumberTestCase.test_bool_from_address() was disabled in 2007 by
  commit 5dc4fe0.
* Remove check_perf() and run_test() of test_numbers.
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jun 15, 2023
@vstinner vstinner enabled auto-merge (squash) June 15, 2023 12:05
@vstinner vstinner merged commit 8f10140 into python:main Jun 15, 2023
carljm added a commit to carljm/cpython that referenced this pull request Jun 15, 2023
* main: (57 commits)
  pythongh-105831: Fix NEWS blurb from pythongh-105828 (python#105833)
  pythongh-105820: Fix tok_mode expression buffer in file & readline tokenizer (python#105828)
  pythongh-105751, test_ctypes: Remove disabled tests (python#105826)
  pythongh-105821: Use a raw f-string in test_httpservers.py (python#105822)
  pythongh-105751: Remove platform usage in test_ctypes (python#105819)
  pythongh-105751: Reenable disable test_ctypes tests (python#105818)
  pythongh-105751: Remove dead code in test_ctypes (python#105817)
  More reorganisation of the typing docs (python#105787)
  Improve docs for `typing.dataclass_transform` (python#105792)
  pythonGH-89812: Churn `pathlib.Path` test methods (python#105807)
  pythongh-105800: Issue SyntaxWarning in f-strings for invalid escape sequences (python#105801)
  pythongh-105751: Cleanup test_ctypes imports (python#105803)
  pythongh-105481: add HAS_JUMP flag to opcode metadata (python#105791)
  pythongh-105751: test_ctypes avoids the operator module (pythonGH-105797)
  pythongh-105751: test_ctypes: Remove @need_symbol decorator (pythonGH-105798)
  pythongh-104909: Implement conditional stack effects for macros (python#105748)
  pythongh-75905: Remove test_xmlrpc_net: skipped since 2017 (python#105796)
  pythongh-105481: Fix types and a bug for pseudos (python#105788)
  Update DSL docs for cases generator (python#105753)
  pythonGH-77273: Better bytecodes for f-strings (pythonGH-6132)
  ...
@vstinner vstinner deleted the test_ctypes_disabled branch June 27, 2023 23:17
@ambv ambv added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Jul 31, 2023
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @vstinner, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8f10140e74d141a0a894702044e213e6f0690d9c 3.11

@miss-islington
Copy link
Contributor

Sorry, @vstinner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8f10140e74d141a0a894702044e213e6f0690d9c 3.12

@ambv
Copy link
Contributor

ambv commented Jul 31, 2023

waiting

@bedevere-bot
Copy link

GH-107483 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jul 31, 2023
ambv pushed a commit to ambv/cpython that referenced this pull request Jul 31, 2023
…105826)

* The following tests were disabled since the initial ctypes commit
  in 2006, commit babddfc:

  * Callbacks.test_char_p()
  * DeletePointerTestCase.test_X()
  * NumberTestCase.test_perf()
  * StructureTestCase.test_subclass_creation()
  * Tests.test_X() of test_byteswap

* NumberTestCase.test_bool_from_address() was disabled in 2007 by
  commit 5dc4fe0.
* Remove check_perf() and run_test() of test_numbers.
(cherry picked from commit 8f10140)

Co-authored-by: Victor Stinner <[email protected]>
ambv pushed a commit to ambv/cpython that referenced this pull request Jul 31, 2023
…105826)

* The following tests were disabled since the initial ctypes commit
  in 2006, commit babddfc:

  * Callbacks.test_char_p()
  * DeletePointerTestCase.test_X()
  * NumberTestCase.test_perf()
  * StructureTestCase.test_subclass_creation()
  * Tests.test_X() of test_byteswap

* NumberTestCase.test_bool_from_address() was disabled in 2007 by
  commit 5dc4fe0.
* Remove check_perf() and run_test() of test_numbers.
(cherry picked from commit 8f10140)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-bot
Copy link

GH-107484 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 31, 2023
ambv added a commit that referenced this pull request Jul 31, 2023
…7483)

* The following tests were disabled since the initial ctypes commit
  in 2006, commit babddfc:

  * Callbacks.test_char_p()
  * DeletePointerTestCase.test_X()
  * NumberTestCase.test_perf()
  * StructureTestCase.test_subclass_creation()
  * Tests.test_X() of test_byteswap

* NumberTestCase.test_bool_from_address() was disabled in 2007 by
  commit 5dc4fe0.
* Remove check_perf() and run_test() of test_numbers.
(cherry picked from commit 8f10140)

Co-authored-by: Victor Stinner <[email protected]>
ambv added a commit that referenced this pull request Jul 31, 2023
…7484)

* The following tests were disabled since the initial ctypes commit
  in 2006, commit babddfc:

  * Callbacks.test_char_p()
  * DeletePointerTestCase.test_X()
  * NumberTestCase.test_perf()
  * StructureTestCase.test_subclass_creation()
  * Tests.test_X() of test_byteswap

* NumberTestCase.test_bool_from_address() was disabled in 2007 by
  commit 5dc4fe0.
* Remove check_perf() and run_test() of test_numbers.
(cherry picked from commit 8f10140)

Co-authored-by: Victor Stinner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants