Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-102856: Add missing quote to fix doctest #104852

Merged
merged 1 commit into from
May 24, 2023
Merged

gh-102856: Add missing quote to fix doctest #104852

merged 1 commit into from
May 24, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented May 24, 2023 •
edited
Loading 

Document: whatsnew/3.12
-----------------------
**********************************************************************
File "whatsnew/3.12.rst", line ?, in default
Failed example:
    f"This is the playlist: {", ".join(songs)}"
Expected:
    'This is the playlist: Take me back to Eden, Alkaline, Ascensionism
Got:
    'This is the playlist: Take me back to Eden, Alkaline, Ascensionism'
**********************************************************************
1 items had failures:
   1 of  12 in default
12 tests in 1 items.
11 passed and 1 failed.
***Test Failed*** 1 failures.

https://github.com/python/cpython/actions/runs/5066957137/jobs/9097400760

Introduced in #104824.

@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir skip news labels May 24, 2023
@hugovk hugovk changed the title Add missing quote to fix doctest gh-102856: Add missing quote to fix doctest May 24, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 24, 2023
Closed
4 tasks
@hugovk hugovk added the needs backport to 3.12 bug and security fixes label May 24, 2023
This was referenced May 24, 2023
Merged
Merged
@hugovk hugovk merged commit 3e97c00 into python:main May 24, 2023
@hugovk hugovk deleted the fix-docs branch May 24, 2023 10:21
@miss-islington
Copy link
Contributor

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2023
@hugovk @miss-islington
pythongh-102856: Add missing quote to fix doctest (pythonGH-104852)
ec62b10 
(cherry picked from commit 3e97c00)

Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-bot
Copy link

GH-104854 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label May 24, 2023
hugovk added a commit that referenced this pull request May 24, 2023
@miss-islington @hugovk
[3.12] gh-102856: Add missing quote to fix doctest (GH-104852) (#104854)
2d685ec 
Co-authored-by: Hugo van Kemenade <[email protected]>
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hugovk @miss-islington @bedevere-bot @AlexWaygood