Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-103592: Add tests of Literal with Enum and Union of Literals #103706

Merged
merged 1 commit into from
Apr 23, 2023
Merged

gh-103592: Add tests of Literal with Enum and Union of Literals #103706

merged 1 commit into from
Apr 23, 2023

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Apr 23, 2023 •
edited by bedevere-bot
Loading

These tests should catch theoretical future regressions similar to ones described in #103592

@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Apr 23, 2023
@bedevere-bot bedevere-bot mentioned this pull request Apr 23, 2023
Closed
@JelleZijlstra JelleZijlstra added the needs backport to 3.11 only security fixes label Apr 23, 2023
@AlexWaygood AlexWaygood merged commit 5041c2b into python:main Apr 23, 2023
@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 23, 2023
@sobolevn @miss-islington
pythongh-103592: Add tests of Literal with Enum and Union of `L…
14db874 
…iteral`s (pythonGH-103706)

(cherry picked from commit 5041c2b)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-bot
Copy link

GH-103720 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Apr 23, 2023
@AlexWaygood
Copy link
Member

@sobolevn, are you up for backporting these tests to typing_extensions as well?

AlexWaygood pushed a commit that referenced this pull request Apr 23, 2023
@miss-islington @sobolevn
[3.11] gh-103592: Add tests of Literal with Enum and Union of `…
4e9635e 
…Literal`s (GH-103706) (#103720)

gh-103592: Add tests of `Literal` with `Enum` and `Union` of `Literal`s (GH-103706)
(cherry picked from commit 5041c2b)

Co-authored-by: Nikita Sobolev <[email protected]>
@sobolevn
Copy link
Member Author

sobolevn commented Apr 23, 2023 •
edited
Loading

Now I realized that I've missed | unions in this PR. Can I please add one more PR with an extra test to test_types?

@AlexWaygood Yeah, sure. Will do tomorrow.

This was referenced Apr 24, 2023
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir topic-typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sobolevn @miss-islington @bedevere-bot @AlexWaygood @JelleZijlstra