-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-83403: Test parent
param in Mock.__init__
#103630
Conversation
I'm not sure it's intended for |
parent is definitely not part of the public API. |
I'm a bit confused. Aren't non-public members of |
In general, yes. parent was an oversight - taking the "private by undocumented approach", but intended to be private. My apologies. |
So, should I remove the docs part? The test looks useful in any case. |
Yes, the test looks useful but remove the docs. |
Done, thanks a lot for the review! 👍 |
parent
param in Mock.__init__
parent
param in Mock.__init__
@voidspace @cjw296 @hugovk friendly ping :) |
I was not able to find any explict tests for
parent
init parameter, so I've added one.If you think that simple doc that I've added is too short (which I believe is good enough already), I can add more details to it.
Skipping news, because there are no user-facing change.